feat: bridgeless support - Githubissues

kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android

https://kirillzyusko.github.io/react-native-keyboard-controller/

MIT License

1.62k stars 67 forks source link

feat: bridgeless support #410

Closed kirillzyusko closed 5 months ago

kirillzyusko commented 6 months ago

📜 Description

Updated react-native to 0.74 (wich has bridgeless mode enabled by default in new arch).

💡 Motivation and Context

We need to support bridgeless mode.

Main changes to make fabric working were:

change a context from which we emit an event (event emitter, not dispatcher);
remove checks for _jsThread on iOS (since it's bridgeless mode -> these variable will be always false);

Also in this PR I had to remove flipper integration to speed up delivery of this PR. Later on I'll probably add this integration back.

Closes https://github.com/kirillzyusko/react-native-keyboard-controller/issues/429 https://github.com/kirillzyusko/react-native-keyboard-controller/issues/394

📢 Changelog

JS

bumed deps;

iOS

removed _jsThread check as in Fabric it'll be always false;

Android

change context for emitting events (now we need to use appContext);

🤔 How Has This Been Tested?

tested locally + on CI using both architectures.

📸 Screenshots (if appropriate):

Everything works as before 🙃

📝 Checklist

[x] CI successfully passed
[x] I added new mocks and corresponding unit-tests if library API was changed

github-actions[bot] commented 6 months ago

📊 Package size report

Current size	Target Size	Difference
129703 bytes	129748 bytes	-45 bytes 📉