kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android
https://kirillzyusko.github.io/react-native-keyboard-controller/
MIT License
1.4k stars 55 forks source link

fix: size diff job #413

Closed kirillzyusko closed 3 months ago

kirillzyusko commented 3 months ago

šŸ“œ Description

Fixed "0 bytes" diff from size-diff job report.

šŸ’” Motivation and Context

It was incorrect metric. Such metric is totally useless.

The original problem was the fact that in new node 18.20.1 prints output gathered from react-native-builder-bob:

> react-native-keyboard-controller@1.11.6 prepare
> bob build

ā„¹ Building target commonjs
ā„¹ Cleaning up previous build at lib/commonjs
ā„¹ Compiling 32 files in src with babel
āœ” Wrote files to lib/commonjs
ā„¹ Building target module
ā„¹ Cleaning up previous build at lib/module
ā„¹ Compiling 32 files in src with babel
āœ” Wrote files to lib/module
ā„¹ Building target typescript
ā„¹ Cleaning up previous build at lib/typescript
ā„¹ Generating type definitions with tsc

And such output can not be parsed.

The interesting thing is that 18.19.0 version produced expected result. So in this PR I locked node version for this particular job.

šŸ“¢ Changelog

CI

šŸ¤” How Has This Been Tested?

Tested on CI.

šŸ“ø Screenshots (if appropriate):

image

šŸ“ Checklist

github-actions[bot] commented 3 months ago

šŸ“Š Package size report

Current size Target Size Difference
127209 bytes 127209 bytes 0 bytes šŸ“‰