Closed byazamat closed 4 months ago
Hey @byazamat
Thank you for the report! I'll have a look on why it doesn't work! 👀
Okay, parentScrollViewTarget=-1
because of that we skip scrolling. It resolves to -1
because it gets detected as a horizontal ScrollView
:
I added this condition in this PR: https://github.com/kirillzyusko/react-native-keyboard-controller/pull/443
Seems like I need to find a better way of detection horizontal/vertical ScrollView
👀
@byazamat can you check if https://github.com/kirillzyusko/react-native-keyboard-controller/pull/454 fixes the problem?
@byazamat can you check if #454 fixes the problem?
It seems that this has resolved the problem.
Thanks for your quick response!
@byazamat I merged a PR, but don't know yet when I publish a new version. You can use patch-package
and apply a patch with this fix in your project 👀
I will be eagerly looking forward to the new version. In the meantime, the patch is the optimal solution. @kirillzyusko I am very grateful for your hard work! 🫡
Describe the bug First of all, I want to thank you for this awesome library. When the keyboard is in a closed state and I focus on one of the last inputs, the keyboard overlaps the input, so
KeyboardAwareScrollView
doesn't work as expected. However, if I focus step by step from the first input to the last input, it works perfectly. This issue only occurs oniOS
, onAndroid
, it works as expected.Additionally, when the app is opened from a closed state and any input is pressed, it takes time to focus (you can see this in the video that I provided below). This doesn't seem to have happened before installing the library.
Steps that I have done to start work with the library
Please, can you help me to find the problem? I didn't find issues like mine. I don't understand what I did wrong. I would be really appreciative of your assistance.
Code snippet
Repo for reproducing Here is the minimal repo: GitHub Repo
To Reproduce Steps to reproduce the behavior:
yarn run ios
Expected behavior I think
KeyboardAwareScrollView
should scroll to the focused input like onAndroid
(you can see this in the video that I provided below).Screenshots
IOS
(With problem) https://github.com/kirillzyusko/react-native-keyboard-controller/assets/77745661/e42b0fb8-4429-4ec7-b8ec-d3f2a44077c8Android
https://github.com/kirillzyusko/react-native-keyboard-controller/assets/77745661/1b307f3c-1f5e-4287-b93a-575c682233caSmartphone (please complete the following information):