search

kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android
https://kirillzyusko.github.io/react-native-keyboard-controller/
MIT License
1.75k stars 78 forks source link

`OverKeyboardView` stays on screen even after js-reload #637

Closed kirillzyusko closed 1 month ago

kirillzyusko commented 1 month ago

Describe the bug A clear and concise description of what the bug is.

Code snippet

Reproducible in OverKeyboardView example.

Repo for reproducing

you can use example app.

To Reproduce Steps to reproduce the behavior:

  1. Go to OverKeybaordView example
  2. Click on 'Show'
  3. Press cmd+ctrl+z and select Reload.
  4. See the view present on the screen.

Expected behavior

View should be unmounted, because we reload entire app.

Screenshots

https://github.com/user-attachments/assets/8e3ae0ba-aab5-498b-adbd-d0a5d154ef1c

Smartphone (please complete the following information):

Additional context

Most likely an important lifecycle method with corresponding cleanup is not implemented.

kirillzyusko commented 1 month ago

@thespacemanatee would you mind to test https://github.com/kirillzyusko/react-native-keyboard-controller/pull/638 ? 😅

thespacemanatee commented 1 month ago

@kirillzyusko it works, nice one!