kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android
https://kirillzyusko.github.io/react-native-keyboard-controller/
MIT License
1.77k stars 81 forks source link

fix: run xCode 16 on macos 15 #686

Closed kirillzyusko closed 1 week ago

kirillzyusko commented 1 week ago

📜 Description

An attempt to fix iOS 18 e2e tests.

💡 Motivation and Context

First of all I ahd to run e2e tests on macos-15 runner because of a recent changes introduced in https://github.com/actions/runner-images/issues/10703

I did it, but then turned out, that macos-15 doesn't have iPhone 14 by default. I re-generated assets for iPhone 16 Pro, now e2e tests can start successfully, but for some reasons they don't want to pass - many of tests that rely on matching screenshots detects a difference. Unfortunately I can not detect the diff, because we exceed 90 minutes.

Taking all information above I decided, that current changes are good enough to be merged - later on I can restore iOS 18 e2e tests in CI, but tight now I want to unblock the process of merging other important PRs.

Also iOS 18 tests were not very stable. When I added them I used older macos and older iOS to generate screenshots. Now I updated to necessary XCode version, so I should be able to have 1:1 environment, let's see!

📢 Changelog

E2E

CI

🤔 How Has This Been Tested?

Tested on CI.

📝 Checklist

github-actions[bot] commented 1 week ago

📊 Package size report

Current size Target Size Difference
159580 bytes 159580 bytes 0 bytes 📉