search

kirillzyusko / react-native-wifi-p2p

Library that provide access for working with wi-fi direct (p2p) module in android.
164 stars 32 forks source link

a proposal: use firebase testlab #19

Closed NoamDev closed 4 years ago

NoamDev commented 4 years ago

What do you think about inserting some CI to your development? You can first test using mocks, but then you can test using real devices with firebase testing lab. It won't help you to connect to actual devices probably, but you can check things like initializing discover peers. This way, you'd be able to generally test on new devices and android versions you do not possess. it would have prevented my issue for examaple:)

kirillzyusko commented 4 years ago

Hi @NoamDev It sounds like an awesome idea😎 Unfortunately, right now I don't have enough time for implementing this CI pipeline😒 But you can shoot a MR - it's highly appreciate ☺️

NoamDev commented 4 years ago

Pardon? MR?

kirillzyusko commented 4 years ago

@NoamDev Ah, sorry. In different VCS systems it's called different. So, in GitLab it's MR (merge request), in GitHub it's called PR (pull request). When I wrote MR I meant PR :)

kirillzyusko commented 4 years ago

@NoamDev I hope I see PR soon from you😄 In any case, in a couple of months I’ll try to add support myself - now I can’t, because I’m very busy😞 Thank you for the suggestion😎

NoamDev commented 4 years ago

Just to note, it turns out firebase testing lab does not support wifi direct, so such idea, would have to be implemented using another provider.

On Wed, Apr 29, 2020, 23:14 Kirill Zyusko notifications@github.com wrote:

Closed #19 https://github.com/kirillzyusko/react-native-wifi-p2p/issues/19.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kirillzyusko/react-native-wifi-p2p/issues/19#event-3286312216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2ZP5PDXS6NVUOZATUSSUTRPCDAXANCNFSM4MNR7PMA .

kirillzyusko commented 4 years ago

@NoamDev Do you know any free providers, which give an access to wi-fi?

NoamDev commented 4 years ago

A quick google search suggested kobiton. Free plan includes 120 min/month and 50 devices. And yes, they support wifi. Worth a try I believe, but I too, don't have time for this currently.

kirillzyusko commented 4 years ago

@NoamDev Got it. Thank you for research. Maybe after 1-2 months I can try to integrate it :) In any case - thank you for your time and idea! 😎