search

kirillzyusko / react-native-wifi-p2p

Library that provide access for working with wi-fi direct (p2p) module in android.
174 stars 32 forks source link

Fix release ? #72

Closed seba9999 closed 1 year ago

seba9999 commented 1 year ago

I'm done with gitlab haha can't find a way to request a small change in your release branch for the public strings EXTRAS_GROUP_OWNER_ADDRESS and EXTRAS_GROUP_OWNER_PORT !

Your master branch seems ok but watch out your release branch here : https://github.com/kirillzyusko/react-native-wifi-p2p/blob/64a27689a013637cbef82c293f1637a94615451e/android/src/main/java/io/wifi/p2p/FileTransferService.java#L30

kirillzyusko commented 1 year ago

@seba9999 that's fine. When I merge release branch and will publish to npm I will publish changes from master :)

So I think this MR can be closed ;)

P. S. I will publish 3.4.0 tomorrow 👀