search

kiritokatklian / nova-permission

A Laravel Nova tool for Spatie's laravel-permission library
https://novapackages.com/packages/vyuldashev/nova-permission
MIT License
68 stars 15 forks source link

composer json file update and php 8.2 8.3 added in require section #31

Closed anilkumarthakur60 closed 3 months ago

kiritokatklian commented 3 months ago

@anilkumarthakur60 is there a reason for including the repositories key? This looks to me like something to include in your project's composer.json file instead, so you have the flexibility of using whatever source (composer, vcs, local directory) you want as an end user.

anilkumarthakur60 commented 3 months ago

The repositories key in a composer.json file is used to specify additional repositories where Composer should look for packages. These repositories will be searched for packages in addition to Packagist, which is the default package repository for Composer.

In the provided composer.json file, a repository is defined with the key "nova". This repository is of type "composer", which means it's another Composer repository, and the URL for this repository is "https://nova.laravel.com". This means that when Composer is resolving dependencies and looking for packages, it will also search in this repository.

This is particularly useful when you need to include private packages or packages not listed on Packagist in your project.

kiritokatklian commented 3 months ago

@anilkumarthakur60 I know what repositories is used for, hence my suggestion to use it in your project's composer.json instead. This isn't the package's responsibility.

On a side not: The other changes aren't as necessary either since the package works with PHP 8.0+. I'd rather not specify specific PHP versions aside from the major version going forward.

That said, this smells like a ChatGPT reply gone wrong. Didn't even answer my question given the context in the following sentence. I'm disappointed tbh :|

Closing this PR for now