[rfc] are you sure Sluggable::getRouteKey returns right value?

kirkbushell / eloquence

A drop-in library for certain database functionality in Laravel, that allows for extra features that may never make it into the main project.

MIT License

537 stars 58 forks source link

[rfc] are you sure Sluggable::getRouteKey returns right value? #38

Closed constb closed 8 years ago

constb commented 8 years ago

are you sure Sluggable::getRouteKey returns right value? its name suggests it should return field name, but you are returning $this->slug i.e. a value...

kirkbushell commented 8 years ago

Hmmm, tbh I'm not sure. I mean I've been using the system for at least 18 months now on our platform at work and had zero problems.

kirkbushell commented 8 years ago

Yup, it's correct - the base method returns an attribute value.