kirkbushell / eloquence

A drop-in library for certain database functionality in Laravel, that allows for extra features that may never make it into the main project.
MIT License
537 stars 58 forks source link

Fixed some typos + updated the code to the PSR2 standard #64

Closed Xety closed 7 years ago

Xety commented 7 years ago

Does we need to add to the readme the explanation for the slugField() function that is used to define the slugField ?

public function slugField()
{
    return 'slug';
}

Btw, why this method is defined in protected in the core but not the slugStrategy ? https://github.com/kirkbushell/eloquence/blob/master/src/Behaviours/Sluggable.php#L114-L117

kirkbushell commented 7 years ago

@Xety I think slugStrategy was originally used outside the model, before I found out about bootstrapped methods in traits :) That could be changed to protected now.

kirkbushell commented 7 years ago

Sorry, but there's a few changes you've made that I do not actually agree with. I started writing a review but there's no changes here that I think the project needs, and in some cases makes the documentation less readable, not moreso.