Closed Xety closed 7 years ago
@Xety I think slugStrategy was originally used outside the model, before I found out about bootstrapped methods in traits :) That could be changed to protected now.
Sorry, but there's a few changes you've made that I do not actually agree with. I started writing a review but there's no changes here that I think the project needs, and in some cases makes the documentation less readable, not moreso.
Does we need to add to the readme the explanation for the
slugField()
function that is used to define the slugField ?Btw, why this method is defined in protected in the core but not the
slugStrategy
? https://github.com/kirkbushell/eloquence/blob/master/src/Behaviours/Sluggable.php#L114-L117