Closed antennaio closed 6 years ago
This looks good, thank you @antennaio. I'll do a few more checks and balances before releasing, as there's definitely some core changes here I want to triple-check still hasn't broken anything :)
Hey @kirkbushell I have recently upgraded to laravel 7 and I'm not able to install your package. It would really great if you could provide me some help. Thanks
Hey @jitender65. If you're able to provide PR I can merge it in once done. I don't have time right now to sort out 7.0 issues, but could do within the next 1-2 weeks.
This pull request upgrades Eloquence to make it compatible with Laravel 5.6.
As discussed in https://github.com/kirkbushell/eloquence/issues/68 the
getAttributes
andgetOriginal
methods will no longer be overridden. It seems like it's a breaking but necessary change and that's why it should be properly documented in the Changelog if you decide to merge it in. @kirkbushellAs part of the upgrade the
CountCache
andSumCache
classes were updated too, so that the key is passed to thegetOriginal
method in the correct case. At this point all tests are passing.