search

kirkbushell / eloquence

A drop-in library for certain database functionality in Laravel, that allows for extra features that may never make it into the main project.
MIT License
545 stars 58 forks source link

Should package discovery be used? #90

Closed JayyWalker closed 1 year ago

JayyWalker commented 3 years ago

I've noticed the documentation mentions to add \Eloquence\EloquenceServiceProvider to config/app.php. Most packages use Laravel's automatic package discovery, so it surprised me when this did not show up in the discovered packages list.

Is there a reason why this doesn't use that feature? It's a small amount of work to add so I'm happy to do it if need be.

kirkbushell commented 3 years ago

@JayyWalker just never got around to it. Happy to merge any PR that supports auto-discovery :)

kirkbushell commented 1 year ago

Coming in 11.0.