search

kirksl / karate-runner

VSCode Extension for Karate
https://marketplace.visualstudio.com/items?itemName=kirkslota.karate-runner
MIT License
34 stars 11 forks source link

Is it possible to turn off the Karate syntax highlight? #14

Closed ianrenauld closed 4 years ago

ianrenauld commented 4 years ago

I was very, very happy with this extension to run my Karate tests and I had found another extension to provide Syntax Highlight for my Karate Feature files.

Now with the latest release of this plugin, I really, really don't like the look of the Syntax Highlight that is now provided (it looks awful on my display theme - the images I see in Issue #13 look nice, but that's not my display theme). I can't switch to my previous one, because I lose the Karate Runner feature.

I strongly suggest to provide a way to turn off the new syntax highlight (or even better: split off the syntax highlight into another extension).

kirksl commented 4 years ago

@ianrenauld can you post some screenshots showing the bad experience. i will take your images and discuss with the contributor of this feature. for now you can install a prior version(gear icon) of karate runner to remove the feature as shown in the image. image

ianrenauld commented 4 years ago

I use the standard Monokai color theme and this is what I get. The red color everywhere is a bit much...

Karate Runner

Contrast this with the other extension, which is more soothing:

Feature Syntax Highlight

Thanks for the workaround of using the previous version. Karate Runner is a MUST HAVE extension!

kirksl commented 4 years ago

@ianrenauld thanks for the screenshots. i've forwarded everything on to the contributor. also thank you for the feedback glad to hear we are making a difference!

peterquiel commented 4 years ago

Thanks for the feedback and Indeed, it looks awful.

Explanation: I did not create a new theme, I just created a TextMate Grammar that defines Scopes for tokens. The Given,When,Then,And,But,* stuff is scoped as keyword.language. The theme tells vscode how to colorize the different scopes.

So maybe, it's an attribute of Gherkin syntax, to have that many keywords.

I will try to find "better scopes" that work with the Monokai Theme.

@ianrenauld: As a workaround: You can change the language mode back to feature. You should see Karate in the lower left corner: image

Click and change to feature. Codelense, folding and debugging should work as usual.

kirksl commented 4 years ago

closing as there are sufficient workarounds for now and our goal won't be to turn off highlighting, but to fix all issues in https://github.com/kirksl/karate-runner/issues/13