search

kirkthaker / investopedia-trading-api

An api, written in Python, for Investopedia's paper trading stock simulator.
Other
220 stars 61 forks source link

pull request #19

Open mdjames094 opened 7 years ago

mdjames094 commented 7 years ago

Dear kirkthaker. Please have a look at my pull request. best regards.

kirkthaker commented 7 years ago

Thanks for the pull request! I'm traveling this week, so I'll probably take a good look at it this weekend.

MSXR commented 6 years ago

is this valid use of issue section? Just wondering.

kirkthaker commented 6 years ago

Yep, it's fine. School has taken up way more time than expected so I haven't had as much time for side projects as I would like. I'll get to this eventually, I promise!

Jvinniec commented 6 years ago

@kirkthaker Seeing 3 pull requests that have not been addressed for 4 months makes it seem like this project has reached end-of-life, which I'm sure you don't intend. Given the popularity of this repository (90 stars and 30 forks is certainly more than anything I've ever personally developed), I'm curious if you have considered adding a collaborator or two? People who could step up and make pull request decisions on your behalf. Obviously you would want to choose people who you are comfortable giving control of the repository to, but it would reduce the amount of pressure on your end and keep the project from looking like it's not being supported any more.

Thoughts?

kirkthaker commented 6 years ago

I agree - adding some collaborators would keep to project moving forward. I would love to add a collaborator or two so that the pull requests could be merged without my involvement. However, I'm not sure where I would find collaborators?

Anyone interested in being a collaborator (mostly just merging pull requests and keeping the project alive) can comment below this and LMK, and I'd be happy to add them. I might also make a post in a subreddit if we don't get enough people this way.

josiahdahl commented 6 years ago

@kirkthaker I'd be interesting in helping to maintain.

kirkthaker commented 6 years ago

@josiahdahl I've added you as a collaborator - let me know if you need more permissions. Thanks for helping - I really appreciate it!

josiahdahl commented 6 years ago

@kirkthaker Awesome :) Thanks for merging those PRs as well.