search

kirm / sip.js

Session Initiation Protocol for node.js
MIT License
427 stars 171 forks source link

digest: algorithm should not be quoted #118

Closed clshortfuse closed 7 years ago

clshortfuse commented 7 years ago

SIP requests to Broadsoft systems will fail because the algorithm is quoted when it shouldn't be.

See the official HTML documentation at: https://tools.ietf.org/html/rfc2617#section-3.2.1

Note that, unlike nonce and domain, there should not be a quoted string.

The official SIP Documents also shows it should not have quotation marks:

https://tools.ietf.org/html/rfc3261#section-20.44

WWW-Authenticate: Digest realm="atlanta.com",
        domain="sip:boxesbybob.com", qop="auth",
        nonce="f84f1cec41e6cbe5aea9c8e88d359",
        opaque="", stale=FALSE, algorithm=MD5

Edit: Updated with official SIP documentation.