search

kirontoo / devchallenges

Source repo for all of my https://devchallenges.io submissions
0 stars 0 forks source link

Review comments from Vikram #1

Open vikramvi opened 3 years ago

vikramvi commented 3 years ago

What I liked

  1. Components structure ( index.js, componentName.jsx, componentName.css )

  2. App.jsx looks cleaner

Suggestions / Clarifications

  1. Remove all the files which are not used by project ( default files created by create-react-app )

  2. Why App.jsx and App.css is moved under components ? As all the projects I've seen have kept at same level as index.jsx

  3. Why Nav component has got external styling vs styled component used in Button ?

kirontoo commented 3 years ago

2. Why App.jsx and App.css is moved under components ? As all the projects I've seen have kept at same level as index.jsx

There is no reason behind it besides my own personal preference. I like to leave the src folder uncluttered of too many files. So I moved it into the components folder.

3. Why Nav component has got external styling vs styled component used in Button ?

For the scope of this project the Nav component is only used once. So there was no need to create a styled component.

Thanks for the code review :)