search

kirontoo / devchallenges

Source repo for all of my https://devchallenges.io submissions
0 stars 0 forks source link

Input Components review comments #2

Open vikramvi opened 3 years ago

vikramvi commented 3 years ago

What I liked

  1. Usage of React Router
  2. Nice implementation of Styled component
  3. Liked how button and input comments projects are combined together

Things to improve

  1. hover effect is not very obvious, may be you can increase border thickness
  2. input error, hover doesn't retain red color of border
  3. App.css few class names used for styling not actually present in App.js e.g list, list-name, footer etc

Clarifications

  1. Didn't understand how classes ( row, column, footer ) from InputPage.jsx are styled inside App.css, how does App.css is being used without import ?
kirontoo commented 3 years ago

Clarifications

  1. Didn't understand how classes ( row, column, footer ) from InputPage.jsx are styled inside App.css, how does App.css is being used without import ?

I have those classes (row, column, etc) in the App.css file. Since this is imported in the App component, all of the classes are accessible to all child components of App.

The InputPage and ButtonPage component uses these classes, so instead of redefining them in another .css file, I defined them in the App.css file.

Thanks for the feedback! :)