search

kirsan31 / winforms-datavisualization

System.Windows.Forms.DataVisualization provides charting for WinForms applications.
MIT License
47 stars 19 forks source link

Cleanup code in WinForms Data Visualization #6

Closed paul1956 closed 2 years ago

paul1956 commented 2 years ago

I did a basic code cleanup (no Logic changes), feel free to ignore/close if you are not interested.

kirsan31 commented 2 years ago

Omg - lots of changes to review 😱 I will look into it, thank you @paul1956.

P.s. have you tried the latest V.S. preview (17.4 P5) in terms of #4? There is a discussion on the topic of the designer with Klaus, I hope we will come to something in the end...

kirsan31 commented 2 years ago

@paul1956 thank you, we have only this 2 remaining: https://github.com/kirsan31/winforms-datavisualization/pull/6#discussion_r1008681442 https://github.com/kirsan31/winforms-datavisualization/pull/6#discussion_r1008881965

P.s. I could fix these little things myself if you allowed editing from maintainers when creating the PR.

kirsan31 commented 2 years ago

Thanks @paul1956 👍

paul1956 commented 2 years ago

No idea how to do that. My Git experience in limited to what I find in Google and what VS let's me do. I will try to find out how to change today. I skipped doing anything with pattern matching, are you interested in those cleanups?

kirsan31 commented 2 years ago

No idea how to do that. My Git experience in limited to what I find in Google and what VS let's me do. I will try to find out how to change today.

I do not quite understand what is at stake. I already merged this PR - everything is fine 👍

Oh, if you are talking about this:

P.s. I could fix these little things myself if you allowed editing from maintainers when creating the PR.

Then it's just one tick when creating a PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I skipped doing anything with pattern matching, are you interested in those cleanups?

Thank you, but I think we need to take a break 😂 - it's very tedious to check such a massive code changes (which is why I didn't do it myself in the first place 🙄).