search

kirschbaum-development / eloquent-power-joins

The Laravel magic you know, now applied to joins.
MIT License
1.39k stars 87 forks source link

automatic add GlobalScopes #181

Open matheusbenedet opened 3 months ago

matheusbenedet commented 3 months ago

The package documentation says that to apply global scopes we have to call $join->withGlobalScopes(), but if they are global scopes, it doesn't make sense for me to have to call them, it should be the other way around, if I don't want to, then yes I use withoutGlobalScopes(), but to avoid causing a break, I would suggest a package configuration file to set withGlobalScopes to true, then every join the package checks if it has global scopes and applies it if it does.

Thanks.

luisdalmolin commented 3 months ago

That's reasonable, we are open to PRs if you have any rush on this. The reason to not apply this automatically is that SQL joins are not a 1-1 match with whatever other regular SQL query, so it can get tricky.