Feature/better title handling - Githubissues

kirschbaum-development / nova-inline-relationship

A package to present relationships as inline properties in Nova.

MIT License

196 stars 84 forks source link

Feature/better title handling #31

Closed brandonferens closed 4 years ago

brandonferens commented 4 years ago

This PR address the issue brought up in #7 by @Antimcom.

It basically looks to see if this is a singular relationship from a HasOne, BelongsTo, or MorphOne on the model. And based on that determines if title should be something like "Widget 1" if plural or "Widget" if singular. This affects both the detail and form components.

Key lines to notes for this PR:

RelationshipDetailItem.vue lines 32, 63, and 88-92
RelationshipFormItem.vue lines 19, and 93-97
DetailField.vue line 18

The rest of the lines in this PR are reformatting.

navneetrai commented 4 years ago

@brandonferens looking fine to me.. Great job on ES6 refactors 💯