search

kirschbaum-development / nova-mail

A Laravel Nova action that provides a mail sending form for any resource
MIT License
72 stars 25 forks source link

Localization #22

Closed gabrielesbaiz closed 2 years ago

adammparker commented 4 years ago

Hey @gabrielesbaiz thanks for the contribution! I'll try and get this reviewed as soon as possible. 👍

brandonferens commented 4 years ago

@gabrielesbaiz thanks so much for the PR. In my review of the code, it appears as though there are two separate things going on in it. One is for localization, the other is for adding attachments. Would you mind splitting this into two PR's? Leave the localization code in this one and create a new PR for attachments.

Thanks so much. Having attachments in this package will be extremely helpful too!

adammparker commented 2 years ago

Closing this for now since it's not got any responses in a while and would probably need re-worked since this package was updated quite a bit to support Nova v4.