search

kirui93 / ScenTrees.jl

Julia Package for Generating Scenario Trees and Scenario Lattices for Multistage Stochastic Optimization
MIT License
23 stars 7 forks source link

[JOSS] Title and project setup #8

Closed matbesancon closed 4 years ago

matbesancon commented 4 years ago

The Project.toml doesn't seem to follow Pkg generated style, perform:

julia>]
(ScenTrees) pkg> instantiate
(ScenTrees) pkg> up

modifies the order of packages in Project.toml

The package itself should be referenced in the documentation's project, otherwise, when activate-ing the docs/Project.toml, there is no ScenTrees in the environment.

Following Julia's guidelines on package names, ScenarioTrees.jl might be a more explicit name compared to ScenTrees.jl, this is up to you and won't be a blocking issue for the JOSS review

matbesancon commented 4 years ago

Linking to the review: https://github.com/openjournals/joss-reviews/issues/1912

kirui93 commented 4 years ago

We had a lot of options in terms of naming this package but we preferred ScenTrees as it is unique and it kind of explains more to what we are doing.