search

kisanjong / rotalabutterfly

Planted Tank Nutrient Calculator
6 stars 8 forks source link

Language selection #8

Open kisanjong opened 9 years ago

kisanjong commented 9 years ago

i18n language selection

Multilingual feature

ravenwilde commented 9 years ago

Question for you both:

I have the english language file converted over to a json file and I will probably convert the others over as well. Are you guys okay with this? I don't think they're being used by main.php is that correct @fablau ?

fablau commented 9 years ago

I have the english language file converted over to a json file and I will probably convert the others over as well. Are you guys okay with this? I don't think they're being used by main.php is that correct @fablau ?

Yes, that's correct. Backend crunches just numbers for now :)

kisanjong commented 9 years ago

The drop down selection is showing strange characters unlike the actual calculator that looks fine to me anyway.

screenshot_2015-08-02-07-00-23

kisanjong commented 9 years ago

Just to check this is not a server related related problem?

ravenwilde commented 9 years ago

I'm not sure, it's doing the same thing to me on my local. I need to do some research and figure out what the problem is. I should be back to work on this project tomorrow.

kisanjong commented 9 years ago

I've had a few users ask if we can change the whole site including header menu etc to the selected language.

Thanks

diogorolo commented 9 years ago

I deleted my previous comment because it was inaccurate.
I can fix this in my local by simply adding, in the head, the following:

<meta charset="UTF-8">
kisanjong commented 9 years ago

As easy as that ;) thanks @diogorolo its working perfect now,

I also added it to wets old calc at yanc.rotalabutterfly.com fixing the same problem on that one :)

kisanjong commented 9 years ago

Added to http://rotalabutterfly.com

screenshot_2015-08-25-12-08-25

diogorolo commented 9 years ago

The translations in json/ptbr.json are still wrong though. https://github.com/kisanjong/rotalabutterfly/blob/b9658ee41fe9ceeb35da444e29939b81d268aa9a/json/ptbr.json#L6,L7

kisanjong commented 9 years ago

The translations are all taken from wets calculator, please feel free to update any mistakes :)

Once the main calculator is complete, i will work on the languages.

Thanks

ravenwilde commented 9 years ago

@diogorolo Thanks for solving the menu issue - also, do feel free to update the json/ptbr.json file - I had to make adjustments to Wet's original translations to fit with our new labels and used Google Translate to do so. I'm sure there are tons of errors.