Possible issues with pick_single_element and pick_value logic in LBP algorithm

Also, a corresponding test also being commented out:

// Not sure the test below is valid since X' does not have a single
value, although it does have a single non-free variable to refer
// to; the function definition must be refined to make these
distinctions more clear.
//                new PickValueTestData(Expressions.TRUE.toString(),
//                        new TrivialPQ(),
//                        "X'",
//                        "{X', W}",
//                        "W = X = X' = person1 or W = X = X' = person2
or W = X = X' = person3",
//                        false,
//                        "X"
//                        ),

Rodrigo

On 4/13/2013 6:58 PM, Rodrigo de Salvo Braz wrote:
Found issue with following test:
>
>                 // Ensure the free Variable X is selected and not the
> scoped W variable
>                 // Used to be a test but it was incorrect, since it
> was picking X as a value but the set if not a singleton
>                 // It started doing the right thing (returning null)
> after adding {@link ConjunctsHoldTrueForEachOther} -- not sure why.
>                 // Since that simplification is optional, it means the
> pick single element is not quite correct.
> //                new
> PickSingleElementTestData(Expressions.TRUE.toString(),
> //                        new TrivialSickbob(),
> //                        "{ ( on W in People, X' in People ) (if
> sick(X') then 1 else 0) | W = X = X' = person1 or W = X = X' = person2
> or W = X = X' = person3 }",
> //                        false,
> //                        "if sick(X) then 1 else 0"
> //                        ),

Original issue reported on code.google.com by ctjoreilly@gmail.com on 15 Apr 2013 at 2:47

kiselev / aic-praise

Possible issues with pick_single_element and pick_value logic in LBP algorithm #10