kiselev / aic-praise

Automatically exported from code.google.com/p/aic-praise
0 stars 0 forks source link

Distinction between random variable values and random variable value candidates not as clear as necessary #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Check distinction between random variable value candidates and true random 
variable values

Several methods are using, directly or indirectly,

LPIUtil.isRandomVariableValueExpressionCandidate

even though they should be using

LPIUtil.isRandomVariableValueExpression

Simply changing one for the other breaks tests though. For example

LPIUtil.containsRandomVariableValueExpression

uses the candidate version even though its name implies that it should not.
However, changing it to not use candidates breaks the code because it is used 
in some contexts in which candidates are all we have (and are enough).

This requires quite some cleaning up and careful reviewing of each case. It is 
made more laborious due to indirect uses. Methods using derivatives of these 
methods need to be followed carefully.

Original issue reported on code.google.com by rodrigob...@gmail.com on 22 May 2013 at 4:05

GoogleCodeExporter commented 8 years ago

Original comment by rodrigob...@gmail.com on 28 May 2013 at 6:11

GoogleCodeExporter commented 8 years ago
Subversion revision=844.

Original comment by ctjoreilly@gmail.com on 17 Jun 2013 at 10:12