search

kiselev / aic-praise

Automatically exported from code.google.com/p/aic-praise
0 stars 0 forks source link

Random Variables need to be recognizable even if not mentioned in factors of the model. #4

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
You're right. I will fix that. Thanks.

Rodrigo

On 12/14/2011 7:46 PM, Ciaran O'Reilly wrote:
> Hi Rodrigo,
>
> The logic for checking if something is a random variable appears to only work 
if the random variable is mentioned explicitly in a factor of the model. For 
example, from testMessageToVaraibleFromFactor() -
>
> ... ExampleModel.EMPTY_PQ, "message to [p(X)] from [if p(X) and q(Y) then 3 
else 1]" ...
>
> [p(X)] is failing the test:
>
> BracketedExpressionSubExpressionsProvider.isRandomVariable() due to there 
being no factors in the model.
>
> Let me know what you think.
>
> Thanks

Original issue reported on code.google.com by ctjoreilly@gmail.com on 11 Apr 2013 at 12:33

GoogleCodeExporter commented 8 years ago 
Indirectly fixed as part of issue #13. Test added to confirm Subversion 
revision=846.

Original comment by ctjoreilly@gmail.com on 17 Jun 2013 at 10:47