kishaningithub / hugo-creative-portfolio-theme

Port of the creative portfolio theme to Hugo
https://themes.gohugo.io/hugo-creative-portfolio-theme/
MIT License
446 stars 292 forks source link

Updating to Hugo 0.19 breaks home page layout #12

Closed kaitlinnewson closed 7 years ago

kaitlinnewson commented 7 years ago

I recently updated to Hugo 0.19 (from 0.17), and when I re-built my site that uses this theme, it broke the grid layout on the home page -- the cards were not positioning properly vertically. Reverting back to 0.17 and re-building fixed the issue.

kishaningithub commented 7 years ago

Hi @kaitlinnewson i just tried hugo 0.19 in my demo site hosted in amazon s3 and it seems to work fine.

http://hugo-creative-portfolio.s3-website-us-east-1.amazonaws.com/

Let me know if you did anything specific and it would help me debug the issue.

gchapron commented 7 years ago

Hello @kishaningithub

I have not been able to run properly the theme with the latest version of hugo. After struggling quite a while and seeing this page, I installed hugo 0.17 and it suddenly worked. Here the error message I was having with the latest version of hugo:

macpro-home:mysite Guillaume$ hugo server --theme=hugo-creative-portfolio-theme --buildDrafts WARNING: Site config's rssURI is deprecated and will be removed in a future release. Set baseName in outputFormats.RSS. Started building sites ... ERROR 2017/04/10 14:38:50 Error while rendering "page": template: /Users/Guillaume/Desktop/mysite/themes/hugo-creative-portfolio-theme/layouts/_default/single.html:8:17: executing "/Users/Guillaume/Desktop/mysite/themes/hugo-creative-portfolio-theme/layouts/_default/single.html" at <partial "sidebar.htm...>: error calling partial: template: theme/partials/sidebar.html:13:7: executing "theme/partials/sidebar.html" at <partial "socialButto...>: error calling partial: Partial "socialButtonsInSideBar.html" not found ERROR 2017/04/10 14:38:50 Error while rendering "home": template: /Users/Guillaume/Desktop/mysite/themes/hugo-creative-portfolio-theme/layouts/index.html:8:17: executing "/Users/Guillaume/Desktop/mysite/themes/hugo-creative-portfolio-theme/layouts/index.html" at <partial "sidebar.htm...>: error calling partial: template: theme/partials/sidebar.html:13:7: executing "theme/partials/sidebar.html" at <partial "socialButto...>: error calling partial: Partial "socialButtonsInSideBar.html" not found

Thanks for making this theme!

kaitlinnewson commented 7 years ago

I tried again this morning, and am getting a similar error message to @gchapron after updating to Hugo v 0.20 (via homebrew).

kishaningithub commented 7 years ago

Hi @gchapron and @kaitlinnewson,

Can you check if layouts/partials/socialButtonsInSideBar.html is present inside your themes/hugo-creative-portfolio-theme folder ? The error says its not present but it is there in my repo https://github.com/kishaningithub/hugo-creative-portfolio-theme/blob/master/layouts/partials/socialButtonsInSideBar.html

If its not present can you do a git stash && git pull --rebase once inside your themes/hugo-creative-portfolio-theme directory?

If the issue was not solved can you do a tree -a and place the output here?

kaitlinnewson commented 7 years ago

Hi @kishaningithub,

The layout is present - here's the result of tree -a in the theme folder below.

Also, I'm still noticing that hugo server works fine for me with v0.17, but then as soon as I switch to v0.20, I'm getting the errors as noted above.

.
└── hugo-creative-portfolio-theme
    ├── .DS_Store
    ├── .gitignore
    ├── LICENSE
    ├── README.md
    ├── archetypes
    │   ├── default.md
    │   └── portfolio.md
    ├── layouts
    │   ├── .DS_Store
    │   ├── 404.html
    │   ├── _default
    │   │   ├── baseof.html
    │   │   ├── list.html
    │   │   └── single.html
    │   ├── about
    │   │   └── single.html
    │   ├── contact
    │   │   └── single.html
    │   ├── index.html
    │   └── partials
    │       ├── attribution.html
    │       ├── footer.html
    │       ├── head.html
    │       ├── header.html
    │       ├── mobileNavToggle.html
    │       ├── portfolio.html
    │       ├── scripts.html
    │       ├── sidebar.html
    │       ├── socialButtonsInContact.html
    │       └── socialButtonsInSideBar.html
    ├── static
    │   ├── css
    │   │   ├── bootstrap.min.css
    │   │   ├── bootstrap.min.css.map
    │   │   ├── custom.css
    │   │   ├── font-awesome.min.css
    │   │   ├── fonts
    │   │   │   ├── FontAwesome.otf
    │   │   │   ├── fontawesome-webfont.eot
    │   │   │   ├── fontawesome-webfont.svg
    │   │   │   ├── fontawesome-webfont.ttf
    │   │   │   ├── fontawesome-webfont.woff
    │   │   │   └── fontawesome-webfont.woff2
    │   │   ├── helper.css
    │   │   ├── owl.carousel.css
    │   │   ├── owl.theme.css
    │   │   ├── owl.transitions.css
    │   │   ├── style.blue.css
    │   │   ├── style.default.css
    │   │   ├── style.green.css
    │   │   ├── style.pink.css
    │   │   ├── style.red.css
    │   │   ├── style.sea.css
    │   │   └── style.violet.css
    │   └── js
    │       ├── bootstrap.min.js
    │       ├── ekko-lightbox.js
    │       ├── front.js
    │       ├── imagesloaded.pkgd.min.js
    │       ├── jquery.cookie.js
    │       ├── jquery.min.js
    │       ├── jquery.scrollTo.min.js
    │       ├── main.js
    │       ├── masonry.pkgd.min.js
    │       └── owl.carousel.min.js
    └── theme.toml
kaitlinnewson commented 7 years ago

I just tried creating a new site with the theme and the examplesite, and I'm getting the same error in v0.20 when running hugo server, in case that's helpful.

kaitlinnewson commented 7 years ago

FYI, it looks like this issue is isolated to v0.20, as it works fine when I switch to v0.19.

kaitlinnewson commented 7 years ago

Here's a screenshot of my original issue with the tile display. I'm not seeing it when I use the example site, but am on my own site. The code is available here.

topo_image_bug

kishaningithub commented 7 years ago

@kaitlinnewson Thanks a ton for the detailed explanation of the issue!

Hugo doesn't seem to like camelCase anymore :-P for filenames hence changed to snake case

Have fixed the theme in this commit and have sent you a PR

After the fix this is how your site looked in my dev machine (Layout seems fine)

screen shot 2017-04-12 at 11 24 50 am
kaitlinnewson commented 7 years ago

@kishaningithub Thanks so much for your help! Here's our live site with the theme, in case you're wondering how it's being used :)