kishikawakatsumi / IBPCollectionViewCompositionalLayout

Backport of UICollectionViewCompositionalLayout to earlier iOS 12
MIT License
1.55k stars 148 forks source link

Orthogonal views not respecting trailing contentInset #78

Closed notjosh closed 5 years ago

notjosh commented 5 years ago

There is a regression from 3-4 days ago.

As far as I can tell, top and leading are handled here but there's no corresponding trailing/bottom on the other side.

I tried quickly to track it down, but nothing was obvious to me.

notjosh commented 5 years ago

Repro up on branch: https://github.com/notjosh/IBPCollectionViewCompositionalLayout/tree/sample-orthogonal-trailing-contentinset (ref: OrthogonalScrollingWithInsetsViewController)

In the screenshots, the top section is scrolled all the way to the right.

There are three issues I see here, two are related to contentInset:

OS Without section contentInset With section contentInset
iOS 12.4 image image
iOS 13 image image
kishikawakatsumi commented 5 years ago

Fixed by https://github.com/kishikawakatsumi/IBPCollectionViewCompositionalLayout/pull/85

Thank you for reporting!