kishikawakatsumi / KeychainAccess

Simple Swift wrapper for Keychain that works on iOS, watchOS, tvOS and macOS.
MIT License
7.92k stars 785 forks source link

Add PrivacyInfo.xcprivacy #590

Closed CH3COOH closed 5 months ago

CH3COOH commented 8 months ago

ref: #587 #589

File timestamp APIs were not used in this library. Therefore, I added an empty PrivacyInfo.xcprivacy.

このライブラリでは File timestamp APIs が使われていないため、空のPrivacyInfo.xcprivacyを追加しました。

As pointed out in #589, we are using File timestamp APIs, so I think we need to comply with Privacy Manifests. I have added PrivacyInfo.xcprivacy, but I was unsure whether it is appropriate to set NSPrivacyAccessedAPITypeReasons to 0A2A.1.

#589 での指摘通り、File timestamp APIs を使っているので、Privacy Manifests対応が必要かと思います。 PrivacyInfo.xcprivacy の追加はできましたが、NSPrivacyAccessedAPITypeReasons0A2A.1 にするのが適切かどうか判断できませんでした。

CH3COOH commented 7 months ago

I am not using Swift PM and have not been able to verify that it works correctly, although I have made some changes. I would appreciate if someone could check and comment.

hgraur commented 6 months ago

I am not using Swift PM and have not been able to verify that it works correctly, although I have made some changes. I would appreciate if someone could check and comment.

I added the package from your fork and I can see the PrivacyInfo.xcprivacy file in there. See attached files:

Screenshot 2024-02-28 at 09 47 56 Screenshot 2024-02-28 at 09 48 27

Cheers!

kishikawakatsumi commented 6 months ago

@CH3COOH

File timestamp APIs を使っているので、Privacy Manifests対応が必要かと思います。

creationDateとmodificationDateはこのライブラリ内で定義されているプロパティでFile timestamp APIとは関係ないです。

mushyoom commented 6 months ago

@CH3COOH

File timestamp APIs を使っているので、Privacy Manifests対応が必要かと思います。

creationDateとmodificationDateはこのライブラリ内で定義されているプロパティでFile timestamp APIとは関係ないです。

@CH3COOH ご対応頂いてありがとうございます。

@kishikawakatsumi が確認してくれたように、File timestamp APIを使っていません。 なお、Apple社は空のPrivacyInfo.xcprivacyの追加を推奨していないようです。

PrivacyInfo.xcprivacyの追加はなしでいいかもしれません。

kishikawakatsumi commented 5 months ago

https://forums.developer.apple.com/forums/thread/746481