Migrating errcheck to go/analysis

kisielk / errcheck

errcheck checks that you checked errors.

MIT License

2.33k stars 138 forks source link

Migrating errcheck to go/analysis #165

Closed vitarb closed 3 years ago

vitarb commented 5 years ago

It looks like x/tools/go/analysis is quickly becoming a new standard for writing static analysis in go. Being natively supported by tools like bazel's nogo it provides invaluable ability to unify all linters and perform static analysis at the build time. errcheck being one of the most useful linters outside of go vet should greatly benefit from unification.

Are there any plans for doing this work or would you welcome contributions in this area?

echlebek commented 4 years ago

There aren't any plans to rewrite the tool. Contributions are welcome, but I have to wonder if integrating this library would lead to a wholly different program?

dtcaciuc commented 3 years ago

The package now provides errcheck.Analyzer; see README for short description and API stability disclaimer. This makes errcheck go/analysis-compatible while keeping the existing CLI unchanged.