Closed rmohr closed 2 years ago
@maiqueb FYI
@kisielk thanks for maintaining this great linter.
Looks good to me, can't believe it's been unreported for so long :)
@kisielk would you be willing to create a release container this fix ?
We're keen on it for https://github.com/kubevirt/kubevirt/pull/8058
@maiqueb I just created v1.6.2 which contains the fix. Thanks
@maiqueb I just created v1.6.2 which contains the fix. Thanks
Thank you :) Highly appreciated.
Detect the file beginning by using
pass.Fset.File(f.Pos())
instead of assuming thatf.Pos()
is always the beginning of the file.f.Pos()
is the position of the package keyword which does not always correlate with the beginning of the file.f.Pos()
is not the beginning of the file when there is for instance a comment before the package, which can lead to wrong reportings of the actual error position.