search

kisielk / errcheck

errcheck checks that you checked errors.
MIT License
2.33k stars 138 forks source link

Update dependencies #231

Closed zcalusic closed 10 months ago

zcalusic commented 1 year ago

This fixes errors like this: internal error: package "bytes" without types was imported from "command-line-arguments"

kisielk commented 1 year ago

Looks like this doesn't pass the test suite..

zcalusic commented 1 year ago

It seems that newer version of golang.org/x/tools, which is absolutely required on the currently supported Golang versions 1.19 & 1.20, is not working on older Golang versions.

And your test suite is not testing supported Golang versions at all, just older ones?

Based on the fact that compile on Go 1.18.x went fine, you might consider to not support anything older than 1.18.x anymore?

kisielk commented 10 months ago

This was replaced by #234