search

kisielk / godepgraph

A Go dependency graph visualization tool
MIT License
1.05k stars 90 forks source link

Readable DOT node IDs and enhanced error handling #30

Closed Justin-W closed 6 years ago

Justin-W commented 6 years ago

These enhancements enable: 1) human-readable node and edge tooltips for SVGs generated from godepgraph DOT output; 2) easier debugging (and optional suppression via flag) of import errors during processing.

  1. The effects of the DOT output changes can be seen by examining the change to the 'expected.txt' file (which was updated via godepgraph github.com/kisielk/godepgraph > expected.txt).

  2. Prior to the error-related enhancements, godepgraph was unable to successfully process certain packages without explicitly ignoring any dependencies that caused 'processing errors'. And discovering which packages needed to be excluded was difficult because the godepgraph error messages didn't specify which imports/packages had caused processing to fail.

kisielk commented 6 years ago

Thanks for the PR. I merged it in with the most recent changes. I renamed the flag to -stoponerror and defaulted it to true.