search

kisielk / og-rek

ogórek is a Go library for encoding and decoding pickles.
MIT License
60 stars 16 forks source link

Make decode(encode(v)) to be identity + tuple #33

Closed navytux closed 7 years ago

navytux commented 7 years ago

Hello up there. Please find patches for the following attached:

  1. Adjust encoder so that decode(encode(v)) == v.
  2. Teach ogórek about tuple, so that go programs could produce pickle with real python tuples when needed.
  3. Misc bug fixes.

Please see details in individual commit messages. Patches here build on top of #32.

Thanks beforehand, Kirill

drawks commented 7 years ago

This sounds awesome!

navytux commented 7 years ago

Patches rebased on top of current master. @kisielk please consider to "merge" the work, as all individual commits are prepared to do one thing at a time and do it well with proper description.

Thanks beforehand, Kirill

kisielk commented 7 years ago

Thanks again :) Sorry, I didn't mean to squash the last one but was using github from the phone in the car, not sure why that became the default behaviour..

navytux commented 7 years ago

Thanks for merging and I see about applying the last time - no problem - it is a bit fun to think the patches there were applied while on the go. @drawks thanks also for your feedback.