search

kisielk / vigo

Vi in Go
Other
168 stars 17 forks source link

Added visual mode #25

Closed gchp closed 10 years ago

gchp commented 10 years ago

This adds visual mode selection and movement and ability to delete selection.

It uses the viewTag data structure to manipulate the selection, and stores it in View.VisualRange.

Let me know what you think!

gchp commented 10 years ago

As mentioned in #24, this will need to also include rectangular selection, but I haven't gotten to that bit yet.

kisielk commented 10 years ago

Thanks :) It's looking good. The other thing I think we could do here is move a bunch of the view adjusting etc. in to commands in the commands package, but I'll wait till you get your other changes in.

gchp commented 10 years ago

@kisielk ok, have updated with your feedback. Will look at moving the view adjusting to the commands module now.

kisielk commented 10 years ago

Cool. Looks good for now. I have some other improvements I'd like to make in conjunction with this so I'm going to merge it.

gchp commented 10 years ago

Sweet. Thanks!