search

kisielk / vigo

Vi in Go
Other
168 stars 17 forks source link

Move selection commands to command module #26

Closed gchp closed 10 years ago

gchp commented 10 years ago

Is this what you were thinking?

kisielk commented 10 years ago

Yep, that's much better. The modes should consist mostly of commands being sent in to the commands channel and not much else.

gchp commented 10 years ago

Updated from your comments.

Just noticed an issue with the selection not clearing when existing visual mode. Instead of just adding the FIXME again for this, it might be better to just implement the editor.Redraw() method. It seems like there is a redraw channel created on the editor, which I assume is for this purpose?

kisielk commented 10 years ago

Redraw won't do anything unless the dirty flag is set on the view. I'll see if I can fix that.