search

kislyuk / aegea

Amazon Web Services Operator Interface
Apache License 2.0
68 stars 17 forks source link

limit time we wait for aws detach to succeed before deleting volume #30

Closed boris-dimitrov closed 6 years ago

boris-dimitrov commented 6 years ago

we are seeing a lot of inifinite wait loops where the command aws ec2 detach-volume --volume-id $vid appears to be a no-op, so the loop that is waiting for the volume status to change before deleting the volume becomes an infinite loop

when that happens, the account also exceeds the rate limit for describe-volumes requests, which causes further problems

to address this, we limit the number of retries, and leave it to the account owner to clean up orphaned volumes separately

kislyuk commented 6 years ago

LGTM thank you, will release shortly