kislyuk / aegea

Amazon Web Services Operator Interface
Apache License 2.0
68 stars 17 forks source link

further ameliorate the volume attach/detach polling issues #31

Closed boris-dimitrov closed 6 years ago

boris-dimitrov commented 6 years ago

reduce probability of collisions on devnode

slow down the wait-for-volume-to-attach loop with exponential delays and pid-based jitter so it doesn't run up against api rate limits

boris-dimitrov commented 6 years ago

@kislyuk thanks for your attention to this... the rate limit is now affecting other biohub users in addition to idseq

boris-dimitrov commented 6 years ago

cc @yunfangjuan @jameshowardwang appreciate your eyes on this, i did limited testing on the bash prompt

kislyuk commented 6 years ago

Wow, this is impressively complex. I'm sorry the process of deconflicting these EBS volume mounts is so cumbersome. Unfortunately I'm not aware of any great alternatives on AWS Batch right now.

kislyuk commented 6 years ago

Released in v2.0.0 (this is not really a major release; I'm bumping the major version because my release management script has a bug when bumping multi-digit version components). I did not test this volume management shellcode myself. I'm relying on you guys to tell me if it works :)

boris-dimitrov commented 6 years ago

Thanks Andrey. We are about to put this in production. Will submit any bug fixes to you promptly as we bugs are discovered.