search

kislyuk / aegea

Amazon Web Services Operator Interface
Apache License 2.0
68 stars 17 forks source link

aegea has a lot of old requirements #43

Closed jamestwebber closed 5 years ago

jamestwebber commented 5 years ago

These are starting to become an issue as they get older. For instance, it requires the typing package which conflicts with Python's built-in typing module, breaking it. It also prevents lots of things from being updated. Basically it has to be in its own little environment which is pretty inconvenient for a command-line tool.

kislyuk commented 5 years ago

I've looked through the dependencies for aegea and the only one that is pinned to a version range below the most recent is tweak, which I will update.

I'm confused about the issues that you are experiencing. The typing module is supposed to be a no-op on Python 3.4+ (as described in https://pypi.org/project/typing/). Can you give me the specifics of the issues that you are encountering?

kislyuk commented 5 years ago

Relaxed tweak version range in v2.2.5.

kislyuk commented 5 years ago

The typing module and other dependencies are transitive to the dependency on chalice, which is not required for most of the features of aegea. So I've moved that dependency to be optional. It won't be installed by default now, and requires running pip install aegea[awslambda] to install.

Released in v2.2.6.

jamestwebber commented 5 years ago

This is the issue: https://github.com/allenai/allennlp/pull/1638

Basically new features in Python 3.7 cause the old module to error on import.

kislyuk commented 5 years ago

OK so the issue is just with typing?

jamestwebber commented 5 years ago

That was the issue that caused me to raise this, because it's the first case when aegea's requirements broke something I was doing. Most of the time it's just the cause of a lot of warning messages (e.g. warnings to update pip when you can't because of chalice). Having no warnings is nicer.

kislyuk commented 5 years ago

OK. Closing this because no further action is needed.