Closed tony closed 1 year ago
Hi, thanks for the note. Yes, type hint contributions are welcome (as long as they are added to the code and not as separate stub files, which are hard to maintain).
Hi, thanks for the note. Yes, type hint contributions are welcome (as long as they are added to the code and not as separate stub files, which are hard to maintain).
Bikeshed: do you have a preference for the way its imported?
via a short namespace (e.g. flask style, 2):
import typing as t
def fn(val; str, items: t.List[str]):
...
vs
from typing import List
def fn(val; str, items: List[str]):
...
vs anything else?
In my libs I ended up picking flask's style: import typing as t
.
No preference - feel free to use either style.
Interested in typings?
Downstream this would make completions nicer and let users check argcomplete usage for correctness
(I am happy to contribute them, if so.)