kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

mypy: Basic typings #378

Closed tony closed 1 year ago

tony commented 1 year ago

Fixes #396

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.59% // Head: 80.54% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (25e6db0) compared to base (ed82421). Patch coverage: 44.44% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #378 +/- ## =========================================== - Coverage 80.59% 80.54% -0.06% =========================================== Files 6 6 Lines 737 740 +3 =========================================== + Hits 594 596 +2 - Misses 143 144 +1 ``` | [Impacted Files](https://codecov.io/gh/kislyuk/argcomplete/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk) | Coverage Δ | | |---|---|---| | [argcomplete/\_check\_console\_script.py](https://codecov.io/gh/kislyuk/argcomplete/pull/378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk#diff-YXJnY29tcGxldGUvX2NoZWNrX2NvbnNvbGVfc2NyaXB0LnB5) | `0.00% <0.00%> (ø)` | | | [argcomplete/\_check\_module.py](https://codecov.io/gh/kislyuk/argcomplete/pull/378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk#diff-YXJnY29tcGxldGUvX2NoZWNrX21vZHVsZS5weQ==) | `39.06% <25.00%> (-0.63%)` | :arrow_down: | | [argcomplete/my\_argparse.py](https://codecov.io/gh/kislyuk/argcomplete/pull/378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk#diff-YXJnY29tcGxldGUvbXlfYXJncGFyc2UucHk=) | `81.66% <100.00%> (+0.20%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

SchoolGuy commented 1 year ago

@tony Anything one can do to help you get this ready to be merged and afterwards merged? I would be interested in this.

tony commented 1 year ago

@SchoolGuy I just need more time 🙏

@kislyuk There seems to be more interest in mypy than just me. I will continue this over the next few weeks

tony commented 1 year ago

@kislyuk This is mypy w/ default settings. It should be fine to merge as-is. What do you think?

I will make a second PR based on this with full typings.

cc: @SchoolGuy The PR with annotations won't be until the follow up PR.

kislyuk commented 1 year ago

Thanks, LGTM

kislyuk commented 1 year ago

@tony FYI I'm going to revert the pytest changes as I don't want to make the impression that this project supports pytest. We run tests with unittest and plan to continue to do so.

tony commented 1 year ago

@kislyuk that is fine. The door is open to py.test in the future any time should you like.