Closed tony closed 1 year ago
Base: 80.59% // Head: 80.54% // Decreases project coverage by -0.05%
:warning:
Coverage data is based on head (
25e6db0
) compared to base (ed82421
). Patch coverage: 44.44% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@tony Anything one can do to help you get this ready to be merged and afterwards merged? I would be interested in this.
@SchoolGuy I just need more time 🙏
@kislyuk There seems to be more interest in mypy than just me. I will continue this over the next few weeks
@kislyuk This is mypy w/ default settings. It should be fine to merge as-is. What do you think?
I will make a second PR based on this with full typings.
cc: @SchoolGuy The PR with annotations won't be until the follow up PR.
Thanks, LGTM
@tony FYI I'm going to revert the pytest changes as I don't want to make the impression that this project supports pytest. We run tests with unittest and plan to continue to do so.
@kislyuk that is fine. The door is open to py.test in the future any time should you like.
Fixes #396