kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

Update importlib-metadata dependency requirements to include versions ^5.0.0 #389

Closed aluuu closed 1 year ago

aluuu commented 1 year ago

Why:

argcomplete appears to be a dependency of many packages and can't be installed along with packages that require importlib-metadata>=5 pacakge (e.g. djlint, in my case, but I'm sure there will be more in future). This change makes such installations possible.

aluuu commented 1 year ago

Hello @tony @kislyuk,

It doesn't seem that github allows me to request review from you guys via assigning reviewers while creating a PR, so here I am asking for review and the workflow run approval :)

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.59% // Head: 80.59% // No change to project coverage :thumbsup:

Coverage data is based on head (6c138a7) compared to base (95cd8bb). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #389 +/- ## ======================================== Coverage 80.59% 80.59% ======================================== Files 6 6 Lines 737 737 ======================================== Hits 594 594 Misses 143 143 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.