kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

Support PowerShell #405

Closed bebound closed 1 year ago

bebound commented 1 year ago

Reopen #392 and fix the README.rst

bebound commented 1 year ago

There are still some errors, I'll fix them.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.38 :warning:

Comparison is base (a5b23ce) 80.54% compared to head (91e82fe) 80.16%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #405 +/- ## =========================================== - Coverage 80.54% 80.16% -0.38% =========================================== Files 6 6 Lines 740 746 +6 =========================================== + Hits 596 598 +2 - Misses 144 148 +4 ``` | [Impacted Files](https://codecov.io/gh/kislyuk/argcomplete/pull/405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk) | Coverage Δ | | |---|---|---| | [argcomplete/shell\_integration.py](https://codecov.io/gh/kislyuk/argcomplete/pull/405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk#diff-YXJnY29tcGxldGUvc2hlbGxfaW50ZWdyYXRpb24ucHk=) | `85.36% <42.85%> (-8.92%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kislyuk commented 1 year ago

Thank you

kislyuk commented 1 year ago

@bebound can you please update this so that the file register-python-argcomplete.cmd does not get installed on non-Windows platforms by default?

kislyuk commented 1 year ago

I have deleted the file scripts/register-python-argcomplete.cmd and will not be adding it back. In general, scripts for contributor-supported shells will need to be installed by separate means activated via setuptools extras.

bebound commented 1 year ago

Windows user cannot run register-python-argcomplete without this cmd file.

kislyuk commented 1 year ago

I understand. We need to find a way to only install this file on Windows.

bebound commented 1 year ago

How about using entry_points? https://github.com/bebound/argcomplete/tree/entry-point It works on Linux and Windows. I don't know if it is compatible with tch.