search

kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

Make fish optional. #410

Closed mcepl closed 1 year ago

mcepl commented 1 year ago

The test suite should not fail because of missing fish on the system.

We are maintaining this package for SLE, where fish is not present (or very old one), and I don’t think it is necessary for building the package to make fish actually required. If it is not present, then the fish-related functionality won’t be tested and that’s it.

kislyuk commented 1 year ago

Thanks. Agreed, fish is optional.

kislyuk commented 1 year ago

Thanks for the PR. I ended up going with a slightly different approach. Fish tests are now disabled by default.