kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

allow importlib-metadata 6.x #424

Closed reaperhulk closed 1 year ago

reaperhulk commented 1 year ago

I'm not actually sure if this works, but the 3.7 CI jobs should hopefully show whether this is safe 😄

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (da2d660) 81.29% compared to head (a857a4c) 81.29%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #424 +/- ## ======================================== Coverage 81.29% 81.29% ======================================== Files 10 10 Lines 770 770 ======================================== Hits 626 626 Misses 144 144 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kislyuk commented 1 year ago

Thanks. I'm seeing an issue in Python 3.7 CI, but I'm not certain that it's related to importlib-metadata. Need to investigate.

reaperhulk commented 1 year ago

Yeah, it appears there's a failure that also occurs in 5.x (as you filed an issue about it in #420)

kislyuk commented 1 year ago

OK, Python 3.7 is EOL soon anyway so I've marked these tests as skip as well.

Released in v3.0.6. If anyone sees any issues with importlib_metadata > 4 on Python 3.7, please let me know and we can troubleshoot.