search

kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

setup.py -> pyproject.toml migration start #427

Closed halfow closed 1 year ago

halfow commented 1 year ago

363

A starting point to make it easier to talk about

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.84 :warning:

Comparison is base (f3f856b) 81.29% compared to head (56b4f04) 80.46%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #427 +/- ## =========================================== - Coverage 81.29% 80.46% -0.84% =========================================== Files 10 10 Lines 770 778 +8 =========================================== Hits 626 626 - Misses 144 152 +8 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/kislyuk/argcomplete/pull/427/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kislyuk commented 1 year ago

Thanks for making the changes!

It looks like setuptools wants version to be in pyproject.toml if project is in pyproject.toml. I think this forces a migration of my release tooling (common.mk) to setuptools_scm.

halfow commented 1 year ago

@kislyuk how do you want to proceed?

I can make the tweaks to use setuptool-scm for versioning if that is something that is in the backlog and should be done any way. :)

kislyuk commented 1 year ago

@halfow would love it if you could contribute that. You'd need to edit common.mk to update the release scripting. Here is another project of mine that already uses setuptools_scm, for reference: https://github.com/pyauth/tsp-client

kislyuk commented 1 year ago

Thanks.