Closed bebound closed 1 year ago
Patch coverage: 60.00
% and project coverage change: -0.17
:warning:
Comparison is base (
f3f856b
) 81.29% compared to head (048c7d5
) 81.13%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks. It would be best to have a unit test for this, but we've never managed to get powershell to run in unit tests. I trust you have tested this and it works for you.
Actually, I think there is a problem that will have to be corrected before I release this. I don't think the presence of PSModulePath
is a sufficiently positive signal that we're running in powershell. It might be set in other shells through some sort of common configuration mechanism.
Instead, the variable _ARGCOMPLETE_SHELL
should be set to powershell
in https://github.com/kislyuk/argcomplete/blob/develop/argcomplete/shell_integration.py#L101-L107 and its value matched instead of PSModulePath
.
@bebound I fixed the issue with the environment variables. Will you please confirm that the fix actually worked for you and report the version of powershell that you used?
Thans for the fix in https://github.com/kislyuk/argcomplete/commit/fe6ecb5a369cb70c318ef13ef0ede96afb667cb2 It works on PS 5.1.22621.1778.
Related issue: https://github.com/Azure/azure-cli/issues/26526
Argcomplete escape the special_chars with
\
when get completion. The result is incorrect on PowerShell. For example. space will be converted to\
, but it should be`