kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

Ensure Python 3.7 compatibility in check_console_script #436

Closed flu0r1ne closed 1 year ago

flu0r1ne commented 1 year ago

The importlib backport, importlib_metadata, returns a tuple of entry points instead of a dictionary keyed by entry group. This inconsistency caused a KeyError exception to be thrown. To resolve this issue, the script has been adjusted to maintain compatibility with Python 3.7, as specified in setup.py.

May resolve #435.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.63 :warning:

Comparison is base (f3f856b) 81.29% compared to head (2b528f4) 80.67%.

:exclamation: Current head 2b528f4 differs from pull request most recent head eae4768. Consider uploading reports for the commit eae4768 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #436 +/- ## =========================================== - Coverage 81.29% 80.67% -0.63% =========================================== Files 10 10 Lines 770 771 +1 =========================================== - Hits 626 622 -4 - Misses 144 149 +5 ``` | [Impacted Files](https://app.codecov.io/gh/kislyuk/argcomplete/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk) | Coverage Δ | | |---|---|---| | [argcomplete/\_check\_console\_script.py](https://app.codecov.io/gh/kislyuk/argcomplete/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk#diff-YXJnY29tcGxldGUvX2NoZWNrX2NvbnNvbGVfc2NyaXB0LnB5) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/kislyuk/argcomplete/pull/436/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Kislyuk)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.