search

kislyuk / argcomplete

Python and tab completion, better together.
https://kislyuk.github.io/argcomplete/
Apache License 2.0
1.39k stars 129 forks source link

Fix path to pexpect's bashrc #485

Closed mgorny closed 1 month ago

mgorny commented 1 month ago

Fix path to pexpect's bashrc, to make tests more reliable. The path was changed in 46e6e7509fa2ab888b51d397658f59841d0c0917 to replwrap/bashrc.sh inside pexpect package; however, FWICS no such directory ever existed and the bashrc file was always directly inside the package directory.

Without this change, pexpect's bashrc is not loaded and tests fail when user's bashrc results in a long prompt. In my case, they failed on a system with a 12-character hostname (and passed on a system with a 6-character hostname).

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.21%. Comparing base (c7cc834) to head (d60a9cc).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #485 +/- ## =========================================== + Coverage 81.09% 81.21% +0.12% =========================================== Files 10 10 Lines 788 788 =========================================== + Hits 639 640 +1 + Misses 149 148 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kislyuk commented 1 month ago

Thanks!

mgorny commented 1 month ago

Thanks!