kismetwireless / kismet-packages

Packaging scripts and related configs for distributing Kismet
GNU General Public License v2.0
28 stars 16 forks source link

Python2, package requirements requirement for OpenWRT packages? #7

Open kitchung opened 3 years ago

kitchung commented 3 years ago

Do we actually need python2 and the python3-cython and python3-numpy (v1.19.1) packages?

The Makefiles RTLSDR capture packages for Kismet along with Python packages (cython, numpy, protobuf websocket) have the following denoting the dependencies for both Python 2.x and 3.x:

include $(TOPDIR)/feeds/packages/lang/python/python-package.mk
include $(TOPDIR)/feeds/packages/lang/python/python3-package.mk

The Setup.py for the these capture packages have only a dependency for Python >=3.2: python_requires='>=3.2',

OpenWRT currently supports Python3 with Python2 moved to https://github.com/openwrt/packages-abandoned

I've successfully in compiled for for openWRT-21.02 after commenting out the need for python-package.mk:

python3-cython never became a dependency for me and I used python3-numpy from OpenWRT's feed instead.

Am i missing anything by commenting out python3, using OpenWRT's python3-numpy (v1.20.2) package and not compiling this repo's python3-cython?

Caveat: I'm a beginner with Kismet and intermediate in building software.

kitchung commented 3 years ago

Can the python2 dependencies be removed since it appears to be resolved with the commits cited in kismetwireless/kismet#159?

kismetwireless commented 3 years ago

Where are the python2 deps? I must be missing them offhand.

-m

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, July 19th, 2021 at 9:46 PM, kitchung @.***> wrote:

Can the python2 dependencies be removed since it appears to be resolved with the commits cited in kismetwireless/kismet#159?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

kitchung commented 2 years ago

Looks like you took care of this via this commit? https://github.com/kismetwireless/kismet-packages/commit/5e5ee6920fc30bfee39183b881efc9143533af85